Project

General

Profile

Bug #42516

mds: some mutations have initiated (TrackedOp) set to 0

Added by Patrick Donnelly 9 months ago. Updated 9 months ago.

Status:
New
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature:

Description

From Brad:

I was looking for tracker ops that had been created with 'initiated'
set to zero and came across this code.

src/mds/Mutation.h:

158 // keep our default values synced with MDRequestParam's
159 MutationImpl() : TrackedOp(nullptr, utime_t()) {}

This default constructor is used quite a bit and results in TrackedOps
with 'initiated' set to zero.

src/mds/Locker.cc
2447: MutationRef mut(new MutationImpl());
3157: MutationRef mut = new MutationImpl();
3449: MutationRef mut(new MutationImpl());
4479: MutationRef mut(new MutationImpl());

src/mds/Migrator.cc
1334: it->second.mut = new MutationImpl();
2583: it->second.mut = new MutationImpl();

src/mds/CInode.cc
2258: MutationRef mut(new MutationImpl());

src/mds/MDCache.cc
528: MutationRef mut(new MutationImpl());
6446: MutationRef mut(new MutationImpl());

I'm not suggesting this is the source of the issue since I would have
no idea how the creation of a MutationImpl object would translate into
an MOSDECSubOpRead/Reply on the OSD nor how this would possibly
affect rgw or rbd tests but I thought I'd see what you thought about
this code.

This may not be a problem as the value maybe gets set some other way?

History

#1 Updated by Patrick Donnelly 9 months ago

  • Assignee set to Ramana Raja

Also available in: Atom PDF