Bug #42317: mimic: incomplete backport LibCephFS.mount in cephfs.pyx needs it's method signature updated - CephFS - Ceph

Actions

Copy link

Bug #42317

closed

mimic: incomplete backport LibCephFS.mount in cephfs.pyx needs it's method signature updated

Added by Rishabh Dave over 4 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Nathan Cutler

Category:

Target version:

Ceph - v13.2.7

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

Ceph - v13.2.7

ceph-qa-suite:

Component(FS):

VolumeClient

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

I came across this issue while trying to reproduce the issue here.

On mimic branch ceph_volume_client.py's CephFSVolumeClient.connect() passes an arg to mount (see [1]) -

            log.debug("Premount eviction of {0} completes".format(premount_evict))
        log.debug("CephFS mounting...")
        self.fs.mount(filesystem_name=to_bytes(self.fs_name))

But cephfs.pyx's `LibCephFS.mount` doesn't accept any arg besides `self` (see [2]) -

 def mount(self):

This is due to an incomplete backport - https://github.com/ceph/ceph/commit/1ab18fcf056ef8e4fcb9ed27e64ee4f8a75866dc

How to reproduce

On a latest mimic cluster setup by vstart.sh, run test_volclient.py (attached) to see the error and the traceback.
Running any test from test_volume_client.TestVolumeClient would also work but the real error message would be hidden behind CommandFailedError.

Files

test_volclient.py (501 Bytes) test_volclient.py

Rishabh Dave, 10/15/2019 05:53 AM

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nathan Cutler over 4 years ago

Indeed, https://github.com/ceph/ceph/commit/153a8cb025da7a500356d65f80792c1b51de71fe was merged for nautilus and I can't find any mention of it in mimic, so I assume it was never backported.

Actions

Copy link

Updated by Nathan Cutler over 4 years ago

@Rishabh Is it enough to cherry-pick 153a8cb025da7a500356d65f80792c1b51de71fe to mimic? I see it applies cleanly.

Actions

Copy link

Updated by Nathan Cutler over 4 years ago

Related to Backport #40896: mimic: ceph_volume_client: fs_name must be converted to string before using it added

Actions

Copy link

Updated by Nathan Cutler over 4 years ago

Priority changed from Normal to Urgent

Actions

Copy link

Updated by Patrick Donnelly over 4 years ago

Target version set to v13.2.7
Start date deleted (~~10/15/2019~~)
Source set to Development

Actions

Copy link

Updated by Rishabh Dave over 4 years ago

@Nathan Weinberg

@Rishabh Is it enough to cherry-pick 153a8cb025da7a500356d65f80792c1b51de71fe to mimic? I see it applies cleanly.

Just cherry pick this commit and not the entire PR, right?

Actions

Copy link

Updated by Nathan Cutler over 4 years ago

Rishabh Dave wrote:

Just cherry pick this commit and not the entire PR, right?

Glancing at the code, I don't see any reason why cherry-picking just this one commit and not the entire PR "libcephfs: enable convenient use of multiple filesystems" [1] would cause any problems (when the filesystem argument is empty, it should default to the value of "client_mds_namespace"), but better ask Patrick to be sure.

[1] https://github.com/ceph/ceph/pull/23530

Actions

Copy link