Project

General

Profile

Bug #40997

mgr/prometheus: Setting scrape_interval breaks cache timeout comparison

Added by Ben Meekhof almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
prometheus module
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, mimic, luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If set by user scrape_interval option is returned as non-float by get_localized_module_option when setting the internal collect_timeout variable. The result is that the cache timeout comparison always returns true and data is never refreshed. The module just keeps returning the cache for every scrape request.


Related issues

Copied to mgr - Backport #41277: mimic: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison Resolved
Copied to mgr - Backport #41278: luminous: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison Resolved
Copied to mgr - Backport #41279: nautilus: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison Resolved

History

#1 Updated by Ben Meekhof almost 2 years ago

Detail on setting option and recreating issue. Any setting will cause the problem:

ceph config set mgr mgr/prometheus/scrape_interval 8.0

#2 Updated by Greg Farnum almost 2 years ago

  • Project changed from Ceph to mgr
  • Category set to prometheus module

#3 Updated by Jan Fajerski almost 2 years ago

  • Backport set to nautilus, mimic, luminous
  • Pull request ID set to 29382
  • Affected Versions v15.0.0 added
  • Affected Versions deleted (v9.2.1)

#4 Updated by Jan Fajerski almost 2 years ago

  • Status changed from New to Pending Backport

#5 Updated by Nathan Cutler almost 2 years ago

  • Copied to Backport #41277: mimic: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added

#6 Updated by Nathan Cutler almost 2 years ago

  • Copied to Backport #41278: luminous: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added

#7 Updated by Nathan Cutler almost 2 years ago

  • Copied to Backport #41279: nautilus: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added

#8 Updated by Nathan Cutler over 1 year ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF