Project

General

Profile

Actions
Copy link

Bug #40997

closed

mgr/prometheus: Setting scrape_interval breaks cache timeout comparison

Added by Ben Meekhof over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
prometheus module
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, mimic, luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v15.0.0
ceph-qa-suite:
Pull request ID:
29382
Crash signature (v1):
Crash signature (v2):

Description

If set by user scrape_interval option is returned as non-float by get_localized_module_option when setting the internal collect_timeout variable. The result is that the cache timeout comparison always returns true and data is never refreshed. The module just keeps returning the cache for every scrape request.

Related issues 3 (0 open — 3 closed)

Copied to mgr - Backport #41277: mimic: mgr/prometheus: Setting scrape_interval breaks cache timeout comparisonResolvedKonstantin ShalyginActions
Copied to mgr - Backport #41278: luminous: mgr/prometheus: Setting scrape_interval breaks cache timeout comparisonResolvedKonstantin ShalyginActions
Copied to mgr - Backport #41279: nautilus: mgr/prometheus: Setting scrape_interval breaks cache timeout comparisonResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Ben Meekhof over 4 years ago

Detail on setting option and recreating issue. Any setting will cause the problem:

ceph config set mgr mgr/prometheus/scrape_interval 8.0

Actions
Copy link
 #2

Updated by Greg Farnum over 4 years ago

  • Project changed from Ceph to mgr
  • Category set to prometheus module
Actions
Copy link
 #3

Updated by Jan Fajerski over 4 years ago

  • Backport set to nautilus, mimic, luminous
  • Pull request ID set to 29382
  • Affected Versions v15.0.0 added
  • Affected Versions deleted (v9.2.1)
Actions
Copy link
 #4

Updated by Jan Fajerski over 4 years ago

  • Status changed from New to Pending Backport
Actions
Copy link
 #5

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #41277: mimic: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added
Actions
Copy link
 #6

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #41278: luminous: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added
Actions
Copy link
 #7

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #41279: nautilus: mgr/prometheus: Setting scrape_interval breaks cache timeout comparison added
Actions
Copy link
 #8

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF