Project

General

Profile

Actions
Copy link

Bug #38626

closed

pg_autoscaler is not Python 3 compatible

Added by Sebastian Wagner about 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
xie xingguo
Category:
pg_autoscaler module
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
QA
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
26831
Crash signature (v1):
Crash signature (v2):

Description

src/scripts/run_mypy.sh revealed some type errors:

from https://gist.github.com/sebastian-philipp/25f70aae3b0d21b1a781c110a7ef8be4

pybind/mgr/pg_autoscaler/module.py: note: In member "get_subtree_resource_status" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:192: error: "Dict[Any, Any]" has no attribute "itervalues" 
pybind/mgr/pg_autoscaler/module.py: note: In member "_maybe_adjust" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:359: error: Name 'cr_name' is not defined
pybind/mgr/pg_autoscaler/module.py:410: error: "Dict[Any, float]" has no attribute "iteritems" 
pybind/mgr/pg_autoscaler/module.py:437: error: "Dict[Any, int]" has no attribute "iteritems"

Those errors look like some incompatibilities to Python 3.

Related issues 1 (0 open — 1 closed)

Copied to mgr - Backport #38982: nautilus: pg_autoscaler is not Python 3 compatibleResolvedSage WeilActions
Actions
Copy link

Also available in: Atom PDF