Project

General

Profile

Bug #38626

pg_autoscaler is not Python 3 compatible

Added by Sebastian Wagner over 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
pg_autoscaler module
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
QA
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

src/scripts/run_mypy.sh revealed some type errors:

from https://gist.github.com/sebastian-philipp/25f70aae3b0d21b1a781c110a7ef8be4

pybind/mgr/pg_autoscaler/module.py: note: In member "get_subtree_resource_status" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:192: error: "Dict[Any, Any]" has no attribute "itervalues" 
pybind/mgr/pg_autoscaler/module.py: note: In member "_maybe_adjust" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:359: error: Name 'cr_name' is not defined
pybind/mgr/pg_autoscaler/module.py:410: error: "Dict[Any, float]" has no attribute "iteritems" 
pybind/mgr/pg_autoscaler/module.py:437: error: "Dict[Any, int]" has no attribute "iteritems" 

Those errors look like some incompatibilities to Python 3.


Related issues

Copied to mgr - Backport #38982: nautilus: pg_autoscaler is not Python 3 compatible Resolved

History

#1 Updated by Sebastian Wagner over 1 year ago

the cr_name issue was fixed with https://github.com/ceph/ceph/pull/26831

#2 Updated by Sebastian Wagner over 1 year ago

  • Description updated (diff)

#3 Updated by Sebastian Wagner over 1 year ago

  • Backport set to nautilus

#4 Updated by Sage Weil over 1 year ago

  • Status changed from New to Pending Backport

#5 Updated by Nathan Cutler over 1 year ago

  • Copied to Backport #38982: nautilus: pg_autoscaler is not Python 3 compatible added

#6 Updated by Nathan Cutler over 1 year ago

  • Assignee set to xie xingguo
  • Pull request ID set to 26831

#8 Updated by Nathan Cutler over 1 year ago

Sebastian Wagner wrote:

The other PR is https://github.com/ceph/ceph/pull/27154

And here's another: https://github.com/ceph/ceph/pull/27079 ( partially backported to nautilus by https://github.com/ceph/ceph/pull/27387 )

(This is in addition to https://github.com/ceph/ceph/pull/26831 which is reflected in the "Pull request ID" field of this tracker issue... - that one was merged into master before nautilus was released.)

#9 Updated by Sebastian Wagner about 1 year ago

  • Category set to pg_autoscaler module

#10 Updated by Sebastian Wagner 11 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF