Project

General

Profile

Bug #38473

Except ceph-volume lvm batch to handle explicit --wal-devices and --db-devices

Added by Joshua Schmid 7 months ago. Updated 8 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
02/25/2019
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

When the following command is issued:

ceph-volume lvm batch /dev/vdb /dev/vdc /dev/vdd /dev/vde /dev/vdf --wal-devices /dev/vdg /dev/vdh --db-devices /dev/vdg /dev/vdh --yes

I'd expect ceph-volume to allocate the wal alongside the db devices.

This happens:

Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-3c0998ee-f302-4412-a4d5-d4ad7598d072 /dev/vdb
stdout: Physical volume "/dev/vdb" successfully created.
stdout: Volume group "ceph-block-3c0998ee-f302-4412-a4d5-d4ad7598d072" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-dd16bb89-34bd-460c-8bc3-a7680419deaf /dev/vdc
stdout: Physical volume "/dev/vdc" successfully created.
stdout: Volume group "ceph-block-dd16bb89-34bd-460c-8bc3-a7680419deaf" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-e1aa064c-5167-4e74-b4b3-d3976a08ca1a /dev/vdd
stdout: Physical volume "/dev/vdd" successfully created.
stdout: Volume group "ceph-block-e1aa064c-5167-4e74-b4b3-d3976a08ca1a" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-99df99fa-2402-4676-8c60-db0156cbb307 /dev/vde
stdout: Physical volume "/dev/vde" successfully created.
stdout: Volume group "ceph-block-99df99fa-2402-4676-8c60-db0156cbb307" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-58c2b703-eac1-4bbf-bb8e-2922d07e23da /dev/vdf
stdout: Physical volume "/dev/vdf" successfully created.
stdout: Volume group "ceph-block-58c2b703-eac1-4bbf-bb8e-2922d07e23da" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb /dev/vdg /dev/vdh
stdout: Physical volume "/dev/vdg" successfully created.
stdout: Physical volume "/dev/vdh" successfully created.
stdout: Volume group "ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb" successfully created
Running command: /usr/sbin/vgcreate -s 1G --force --yes ceph-block-wals-d879e099-e03c-41dd-9978-43facfa0e002 /dev/vdg /dev/vdh
stderr: Physical volume '/dev/vdg' is already in volume group 'ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb'
Unable to add physical volume '/dev/vdg' to volume group 'ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb'
/dev/vdg: physical volume not initialized.
Physical volume '/dev/vdh' is already in volume group 'ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb'
Unable to add physical volume '/dev/vdh' to volume group 'ceph-block-dbs-f104ae04-2ed6-4edd-9a21-5afe63e0ccbb'
/dev/vdh: physical volume not initialized.
--> RuntimeError: command returned non-zero exit status: 5
data1:~ #

By the looks of it, c-v tries to apply vgcreate twice (for each --wal-devices/--db-devices) and therefore fails.

Validating the input should happen in c-v imho.


Related issues

Copied to ceph-volume - Backport #41775: mimic: Except ceph-volume lvm batch to handle explicit --wal-devices and --db-devices Duplicate

History

#1 Updated by Jan Fajerski 7 months ago

  • Assignee set to Jan Fajerski

#2 Updated by Jan Fajerski 10 days ago

  • Status changed from New to Pending Backport
  • Backport set to mimic

This is fixed by checking that device lists are disjoint. mimic backport is here https://github.com/ceph/ceph/pull/30334

#3 Updated by Nathan Cutler 10 days ago

  • Copied to Backport #41775: mimic: Except ceph-volume lvm batch to handle explicit --wal-devices and --db-devices added

#4 Updated by Jan Fajerski 8 days ago

  • Status changed from Pending Backport to Resolved

Closing this, Backport is tracked in https://tracker.ceph.com/issues/41083

Also available in: Atom PDF