Project

General

Profile

Actions

Bug #36544

closed

mgr/dashboard: pool creation issue

Added by Alfonso Martínez over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Component - Pools
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Provided you have built the frontend with "--prod" flag,
when you try to create a new pool by clicking on "Add"
you see a blank page instead of the pool creation form.

EXPLANATION

In "master > do_cmake.sh" we have:

${CMAKE} -DCMAKE_BUILD_TYPE=Debug $ARGS "$@" .. || exit 1

This flag

CMAKE_BUILD_TYPE=Debug
that is causing that although yo do:

cd /ceph/build

make mgr-dashboard-frontend-build

... you are building in dev mode (not PROD mode) because of this:

src/pybind/mgr/dashboard/CMakeLists.txt:

if(NOT CMAKE_BUILD_TYPE STREQUAL Debug)
set(npm_command npm run build -- --prod --progress=false)
else()
set(npm_command npm run build -- --progress=false)
endif()

Once you do the frontend build with --prod in master, you are able to reproduce it.

=> A PROVISIONAL HOTFIX In src/pybind/mgr/dashboard/frontend/src/app/app.module.ts

Add:

import { ErasureCodeProfileService } from './shared/api/erasure-code-profile.service';

[...]

providers: [
[...] {
provide: ToastOptions,
useClass: CustomOption
},
ErasureCodeProfileService // <==== Here is the provisional hotfix.
],

IMHO the whole workflow should be reviewed under PROD environment to ensure
that everything is OK.

Actions #1

Updated by Alfonso Martínez over 5 years ago

  • Description updated (diff)
Actions #2

Updated by Tiago Melo over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Tiago Melo
Actions #3

Updated by Tiago Melo over 5 years ago

  • Status changed from In Progress to Fix Under Review
Actions #4

Updated by Tiago Melo over 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions #5

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 137 to Component - Pools
Actions

Also available in: Atom PDF