Project

General

Profile

Actions
Copy link

Bug #351

closed

mds: fix cow on xattrs

Added by Sage Weil over 13 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Greg Farnum
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

in MDCache::cow_inode(),

  oldin->inode = *in->get_previous_projected_inode();
  oldin->symlink = in->symlink;
  oldin->xattrs = in->xattrs;   <---- THIS

should get get_previous_projected_xattrs(), which needs to be implemented intelligently in CInode (like get_projected_xattrs(), but a bit tricky)

Actions
Copy link
 #1

Updated by Sage Weil over 13 years ago

also verify cow_old_inode() doesn't need the same fix

Actions
Copy link
 #2

Updated by Greg Farnum over 13 years ago

  • Status changed from New to 7

Fixed in my local branch on commit:67bb28deb13fb5bc06a379dcc656362e94c7a778. Will merge in with snaprealm/rootsnap changes and set to resolved at that time.

Actions
Copy link
 #3

Updated by Sage Weil over 13 years ago

  • Target version changed from v0.21.2 to v0.22
Actions
Copy link
 #4

Updated by Greg Farnum over 13 years ago

  • Status changed from 7 to Resolved

Yep, rootsnap got merged.

Actions
Copy link
 #5

Updated by John Spray over 7 years ago

  • Project changed from Ceph to CephFS
  • Category deleted (1)
  • Target version deleted (v0.22)

Bulk updating project=ceph category=mds bugs so that I can remove the MDS category from the Ceph project to avoid confusion.

Actions
Copy link

Also available in: Atom PDF