Project

General

Profile

Bug #3465

Unclear error message when running 'ceph osd rm'

Added by Anonymous over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
High
Category:
Monitor
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

I am new to the ceph project and was using man pages to execute commands. I misunderstood the command, and rather than using osd-id, i used osd-name:

#ceph osd rm osd.2  
and received the error:
osd.0 is still up

I should have used:
#ceph osd rm 2
received the output:
marked dne osd.2 (is dne suppose to be "done"?)

the error "osd.0 is still up" is very misleading.
the output SHOULD HAVE been "invalid syntax" and giving a help output for "ceph osd rm {osd-id}", to help the user, rather than send them on a wild goose chase.

History

#1 Updated by Sage Weil over 7 years ago

  • Category set to Monitor
  • Status changed from New to 12
  • Assignee set to Joao Eduardo Luis
  • Priority changed from Normal to High
  • Target version set to v0.55d
  • Source changed from Development to Q/A

arch, i thought i fixed all of these. joao, there is a helper in OSDMonitor that parses a raw # or osd.#; can you maek sure it is used for the 'rm' command (and anything else)?

thanks!

#2 Updated by Joao Eduardo Luis over 7 years ago

Will do.

#3 Updated by Sage Weil over 7 years ago

  • Status changed from 12 to Fix Under Review

pushed to wip-mon-parse

#4 Updated by Joao Eduardo Luis over 7 years ago

Thanks for taking care of this Sage.

I've pushed another two patches on top of it. One of them should be merged with your topmost patch, the other fixes the 'dne' messages and makes the 'osd.X is still up' message a bit more clear.

And everything looks, and works just great to me.

#5 Updated by Sage Weil over 7 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF