Project

General

Profile

Bug #3266

"ceph mds tell 0 dumpcache /etc/passwd" is not cool

Added by Anonymous over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This might have plenty of security implications.

Associated revisions

Revision 336c4ae7 (diff)
Added by Sage Weil about 8 years ago

mds: verify mds tell 'dumpcache <filename>' target does not exist

Open target with O_CREAT|O_EXCL to ensure we don't overwrite some other
important file (like, say, /etc/passwd). This is irritating because there
is not c++ ofstream equivalent for O_EXCL; kludge around it using
ostringstream instead.

Fixes: #3266
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil about 8 years ago

  • Project changed from Ceph to CephFS
  • Priority changed from Normal to Urgent
  • Target version set to v0.61 - Cuttlefish

#2 Updated by Greg Farnum about 8 years ago

Before anybody embarks on solving this, I assume there's a standard way to handle this by outlawing certain kinds of paths or something?

#3 Updated by Sage Weil about 8 years ago

  • Status changed from New to Fix Under Review

wip-3266

#4 Updated by Greg Farnum about 8 years ago

  • Status changed from Fix Under Review to Resolved

Merged in with commit:32aac00c7043aa1564272697879b1c626814b143

Also available in: Atom PDF