Project

General

Profile

Bug #25213

handle ceph_ll_close on unmounted filesystem without crashing

Added by Jeff Layton over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
mimic,luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client, Ganesha FSAL
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Client::_unmount will unmap and tear down all of the open Fh objects before returning. Programs that use the lowlevel interfaces however may hold pointers to these objects, and can issue calls against them. In particular, we may end up calling ceph_ll_close on the Fh after the unmount has returned, which can lead to doing a double put on the object.

Fix ceph_ll_close to be a no-op when the cmount is unmounted. We may need to do similar treatment for other calls as well, but that should at least fix the immediate problem I've seen in ganesha.


Related issues

Copied to CephFS - Backport #26914: mimic: handle ceph_ll_close on unmounted filesystem without crashing Resolved
Copied to CephFS - Backport #26915: luminous: handle ceph_ll_close on unmounted filesystem without crashing Resolved

History

#1 Updated by Jeff Layton over 4 years ago

  • Category set to 109
  • Assignee set to Jeff Layton
  • Component(FS) libcephfs added

#2 Updated by Patrick Donnelly over 4 years ago

  • Priority changed from Normal to High
  • Target version set to v14.0.0
  • Source set to Development
  • Backport set to mimic,luminous
  • Component(FS) Ganesha FSAL added

#3 Updated by Patrick Donnelly over 4 years ago

  • Status changed from New to Fix Under Review

#4 Updated by Patrick Donnelly over 4 years ago

  • Status changed from Fix Under Review to Pending Backport

#5 Updated by Patrick Donnelly over 4 years ago

  • Copied to Backport #26914: mimic: handle ceph_ll_close on unmounted filesystem without crashing added

#6 Updated by Patrick Donnelly over 4 years ago

  • Copied to Backport #26915: luminous: handle ceph_ll_close on unmounted filesystem without crashing added

#7 Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

#8 Updated by Patrick Donnelly over 3 years ago

  • Category deleted (109)
  • Component(FS) Client added
  • Component(FS) deleted (libcephfs)

Also available in: Atom PDF