Project

General

Profile

Feature #24880

pybind/mgr/volumes: restore from snapshot

Added by shi liu over 2 years ago. Updated 10 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:

Description

Old description:

Manila's cephfs driver does not support recovering data from snapshots,The driver uses the ceph_volume_client library.

If implement cephfs_volume_client's `_cp_r` method1, it useful for data recovery of manila cephfs drivers.

[1]: https://github.com/ceph/ceph/blob/master/src/pybind/ceph_volume_client.py#L1390


Related issues

Related to CephFS - Feature #43349: mgr/volumes: provision subvolumes with config metadata storage in cephfs Resolved
Copied to CephFS - Backport #44020: pybind/mgr/volumes: restore from snapshot Resolved

History

#1 Updated by John Spray over 2 years ago

I just checked who wrote that "TODO" comment, and it turns out it was me, even though I have no memory of it :-)

IIRC, the hope was that there would be a "read only clone" mechanism (i.e. a clone but the new share would have a readonly flag set), that would in reality just map the new volume to the proper .snap subdirectory, and we'd only do the full copy on a writable clone. I'm not sure whether the Manila clone API ended up in a form that provides that distinction, so that would be something to check.

#2 Updated by John Spray over 2 years ago

  • Project changed from Ceph to CephFS

#3 Updated by Patrick Donnelly over 2 years ago

  • Assignee set to Ramana Raja
  • Component(FS) VolumeClient added

#4 Updated by Patrick Donnelly over 1 year ago

  • Target version changed from v14.0.0 to v15.0.0

#5 Updated by Patrick Donnelly over 1 year ago

  • Subject changed from ceph_volume_client: Implementation of the cp method to pybind/mgr/volumes: restore from snapshot
  • Description updated (diff)
  • Assignee changed from Ramana Raja to Rishabh Dave
  • Start date deleted (07/12/2018)
  • Backport changed from mimic,luminous to nautilus
  • Component(FS) mgr/volumes added
  • Component(FS) deleted (VolumeClient)

#6 Updated by Patrick Donnelly over 1 year ago

  • Assignee changed from Rishabh Dave to Ramana Raja
  • Priority changed from Normal to Urgent

ceph-csi ticket: https://github.com/ceph/ceph-csi/issues/411

Ramana, I'm reassigning this to you. We need this done quickly.

#7 Updated by Patrick Donnelly about 1 year ago

  • Assignee changed from Ramana Raja to Venky Shankar

#8 Updated by Ramana Raja about 1 year ago

This feature will be used by Ceph CSI to create a PVC from a snapshot [1], and by OpenStack Manila to create a share from a snapshot [2]. Since snapshot from clone might take a while, we'd want a mgr/volumes call to initiate the asynchronous subvolume creation from a subvolume snapshot, and an another call to check the status of the subvolume. The `ceph fs subvolume create` CLI can be extended to trigger the subvolume creation from snapshot and return immediately,
```
ceph fs subvolume create <volname> <subvolname> [--group_name <group_name>] [--size <size>] [--snapshot_source <src snapshot name>] [--subvol_source <src subvolname>]
```
and have an another CLI say
```
ceph fs subvolume show <volname> <subvolname> [--group_name <group_id>]
```
to return the status of the subvolume creation.

See discussion here for more details,
https://github.com/ceph/ceph-csi/issues/411#issuecomment-503669965

It should also be possible to garbage collect the subvolumes that were partially restored from a snapshot.

[1] https://kubernetes.io/docs/concepts/storage/persistent-volumes/#create-persistent-volume-claim-from-volume-snapshot
[2] https://docs.openstack.org/manila/latest/cli/manila.html#manila-create

#9 Updated by Venky Shankar about 1 year ago

clone operation design & interface:

. Interface

Introduce `clone` sub-command in `subvolume snapshot` command
$ ceph fs subvolume snapshot clone <source> <target> [<pool-layout>]

where,
source: (filesystem, group, subvolume, snapshot) tuple
target: (filesystem, group, subvolume) tuple
pool-layout: optional, default to pool-layout of target group

Clone operation is asynchronous. Also, allow clone to a different
subvolume group. Cloning a subvolumegroup is not a requirement.

b. Since clone is asynchronous, what if the snap is removed when clone
is in progress? The clone operation should be canceled and marked as
failed (user interrupted).

c. Clone operation status
Introduce `clone status` subcommand.

#2 subcommand takes "<source> <target>" and displays its status.

$ ceph fs subvolume snapshot clone status <source> <target>

A clone operation can be in the following states:

- not started
- in progress
- failed
- complete

`not started and `in progress` are fairly self-explanatory.

Maintain (or figure out) list of failed clones (and this list needs to be available across mgr restarts and failover so as to provide consistent state to CSI). mgr/volumes should skip over failed clones on restart/failover. Provide a CLI command to clear failed clones.

d. Control operations: Support canceling an on-going clone operation (+ CLI command)

Changes to subvolume provisioning by mgr/volumes:

Maintain subvolume metadata in cephfs -- this would allow mgr/volumes to persist subvolume metadata to satisfy consistent `clone status` reporting across manager restarts and failover. Metadata would also carry "version" of a subvolume that would be bumped up as features get added (cloning a subvolume). Backward compatibility would be maintained so no migration of subvolume to the new format is needed.

#10 Updated by Venky Shankar 12 months ago

  • Related to Feature #43349: mgr/volumes: provision subvolumes with config metadata storage in cephfs added

#11 Updated by Venky Shankar 11 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 32030

clone from a snap: https://github.com/ceph/ceph/pull/32030

Most of this work will be required for restoring a subvolume from a snap.

#12 Updated by Ramana Raja 10 months ago

  • Status changed from Fix Under Review to Pending Backport

#13 Updated by Ramana Raja 10 months ago

  • Copied to Backport #44020: pybind/mgr/volumes: restore from snapshot added

#14 Updated by Ramana Raja 10 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF