Actions
Bug #24030
closedceph-fuse: double dash meaning
% Done:
0%
Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
jcollin@stratocaster:~$ grep -- -v file1 -v
jcollin@stratocaster:~/workspace/cephtest/build$ sudo ./bin/ceph-fuse --localize-reads -- -m localhost:40331 /mnt/cephfs/ 2018-05-07 10:03:51.958 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled. 2018-05-07 10:03:51.966 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled. setting CEPH_OSD_FLAG_LOCALIZE_READS 2018-05-07 10:03:51.966 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled. 2018-05-07 10:03:51.966 7f60edcf1c40 -1 init, newargv = 0x561177dce3e0 newargc=9 fuse: bad mount point `localhost:40331': No such file or directory ceph-fuse[2018-05-07 10:03:51.966 7f60edcf1c40 -1 fuse_parse_cmdline failed. 15994]: fuse failed to initialize
If we don't have a requirement to change the meaning of the next parameter, then what is the actual meaning of a double dash here? I'm able to find only failures when using a double dash. So drop the double dash? (I think this should be verified with other commands too common, as double dash is used everywhere).
Also for ceph-fuse, the double dash cannot be the end of all options. For instance, the check for '-m' is somewhere outside the loop.
https://github.com/ceph/ceph/blob/9b8a74f0372202f7d88be5fe8a7c37b53e913605/src/ceph_fuse.cc#L114
Actions