Actions
Bug #24025
closedRocksDB compression is not supported at least on Debian.
% Done:
0%
Source:
Tags:
rocksdb compression
Backport:
mimic, luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
rocksdb: Compression algorithms supported: rocksdb: Snappy supported: 0 rocksdb: Zlib supported: 0 rocksdb: Bzip supported: 0 rocksdb: LZ4 supported: 0 rocksdb: ZSTD supported: 0
see #22534
Updated by Марк Коренберг almost 6 years ago
Updated by Radoslaw Zarzynski almost 6 years ago
- Assignee set to Radoslaw Zarzynski
Updated by Radoslaw Zarzynski almost 6 years ago
- Status changed from New to In Progress
void DumpSupportInfo(Logger* logger) {
ROCKS_LOG_HEADER(logger, "Compression algorithms supported:");
for (auto& compression : OptionsHelper::compression_type_string_map) {
if (compression.second != kNoCompression &&
compression.second != kDisableCompressionOption) {
ROCKS_LOG_HEADER(logger, "\t%s supported: %d", compression.first.c_str(),
CompressionTypeSupported(compression.second));
}
}
ROCKS_LOG_HEADER(logger, "Fast CRC32 supported: %s",
crc32c::IsFastCrc32Supported().c_str());
}
inline bool CompressionTypeSupported(CompressionType compression_type) {
switch (compression_type) {
case kNoCompression:
return true;
case kSnappyCompression:
return Snappy_Supported();
case kZlibCompression:
return Zlib_Supported();
case kBZip2Compression:
return BZip2_Supported();
case kLZ4Compression:
return LZ4_Supported();
case kLZ4HCCompression:
return LZ4_Supported();
case kXpressCompression:
return XPRESS_Supported();
case kZSTDNotFinalCompression:
return ZSTDNotFinal_Supported();
case kZSTD:
return ZSTD_Supported();
default:
assert(false);
return false;
}
}
inline bool Snappy_Supported() {
#ifdef SNAPPY
return true;
#else
return false;
#endif
}
It looks that the macros SNAPPY
, ZLIB
, ... are undefined on Debian. Need to check why.
Updated by Kefu Chai almost 6 years ago
because we fail to pass -DWITH_SNAPPY etc to cmake while building rocksdb. this bug also impacts rpm package. i can help pull together a patch.
Updated by Kefu Chai almost 6 years ago
- Project changed from bluestore to RADOS
- Assignee changed from Radoslaw Zarzynski to Kefu Chai
Updated by Kefu Chai almost 6 years ago
- Status changed from In Progress to Fix Under Review
Updated by Kefu Chai almost 6 years ago
Updated by Kefu Chai almost 6 years ago
tested
2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: Compression algorithms supported: 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kZSTDNotFinalCompression supported: 0 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kZSTD supported: 0 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kXpressCompression supported: 0 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kLZ4HCCompression supported: 1 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kLZ4Compression supported: 1 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kBZip2Compression supported: 0 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kZlibCompression supported: 1 2018-05-24 17:41:26.398 7f3cc22d22c0 4 rocksdb: kSnappyCompression supported: 1
Updated by Kefu Chai almost 6 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Kefu Chai almost 6 years ago
- Copied to Backport #24279: luminous: RocksDB compression is not supported at least on Debian. added
Updated by Nathan Cutler almost 6 years ago
- Copied to Backport #24297: mimic: RocksDB compression is not supported at least on Debian. added
Updated by Nathan Cutler almost 6 years ago
- Status changed from Pending Backport to Resolved
Actions