Project

General

Profile

Cleanup #2331

Makefile.am:182: `lib/libgtest.a' is not a standard libtool library name

Added by Dan Mick about 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Warning is still happening, despite git clean -fdx, git submodule freshening of various sorts, etc.
This should probably be investigated; build errors are offputting as a first impression.

Associated revisions

Revision 66553d25 (diff)
Added by Sage Weil almost 8 years ago

Makefile: link gtest statically

The problem:

- the unittests link against gtest, and gtest is not installed.  that's
normally fine, but...
- rbd and rados api unit tests link against gtest, and are installed
by 'make install'. they are needed for teuthology runs, etc.
- if we build gtest as an .la library, we can only control whether all
or no .la libraries are linked statically.
- we want librados to be linked dynamically.

The solution:

- build gtest as .a instead of a libtool library
- link it statically, always.

Unit test binaries are bigger now. Oh well...

Fixes: #2331
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil almost 8 years ago

  • Status changed from New to Resolved
  • Target version set to v0.48

Also available in: Atom PDF