Ceph » CephFS

Patrick Donnelly wrote:

Jos, finding out the version of FUSE and of ceph-fuse is valuable. I think the --version switch should be used for both. Please make sure that's the current behavior and adjust the output as necessary.

Patrick,

The current behavior of --version is that it prints only:

ceph version 13.0.1-2834-g9ffbac6fc5 (9ffbac6fc5c7ac23d4a6096c7a9636b9df8efc00) mimic (dev)

(not the FUSE version). This is correct as per ceph-fuse.

Now the problem is that we are calling https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L54 for getting FUSE options, in which --version is used for showing the FUSE version. So we have an ambiguity, when these two usages are combined for 'ceph-fuse -h'. But they are correct if they are displayed individually.

The ambiguity is that in 'ceph-fuse -h' usage, --version option is for displaying FUSE version or ceph-fuse version.

Jos Collin wrote:

Now the problem is that we are calling https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L54 for getting FUSE options, in which --version is used for showing the FUSE version. So we have an ambiguity, when these two usages are combined for 'ceph-fuse -h'. But they are correct if they are displayed individually.

The ambiguity is that in 'ceph-fuse -h' usage, --version option is for displaying FUSE version or ceph-fuse version.

I understand. Is it possible to allow FUSE to process --version as well so that it can print its version. Then ceph-fuse can print Ceph's version and exit.

Patrick Donnelly wrote:

I understand. Is it possible to allow FUSE to process --version as well so that it can print its version. Then ceph-fuse can print Ceph's version and exit.

As per your suggestion, I tried some samples for using --version to display both Fuse Library Version and Ceph's Version. It requires moving global_init() [1] to below the for loop, as the Ceph's version is printing and then exiting within global_init(). This results in an undefined behavior (not working as expected) for other option usages.

So I don't think it is a good idea bringing in the new issues for fixing this minor issue (--version).

[1] https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L86