Project

General

Profile

Actions

Bug #19430

closed

objecter: full_try behavior not consistent with osd

Added by Sage Weil about 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
jewel,kraken
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

on the objecter, we have

    bool respects_full() const {
      return
    (target.flags & (CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_RWORDERED)) &&
    !(target.flags & (CEPH_OSD_FLAG_FULL_TRY | CEPH_OSD_FLAG_FULL_FORCE));
    }

which means that we do resend after full only if neither full_try nor full_force are set.

but on the osd,

  if (write_ordered && !( m->get_source().is_mds() || m->has_flag(CEPH_OSD_FLAG_FULL_FORCE)) &&
      info.history.last_epoch_marked_full > m->get_map_epoch()) {
    dout(10) << __func__ << " discarding op sent before full " << m << " " 
         << *m << dendl;
    return;
  }


Related issues 4 (0 open4 closed)

Related to Ceph - Bug #19133: osd ops (sent and?) arrive at osd out of orderResolved03/02/2017

Actions
Has duplicate Ceph - Bug #19540: .../rados/test.sh: line 9: 29593 Terminated (times out)Duplicate04/06/2017

Actions
Copied to Ceph - Backport #19559: jewel: objecter: full_try behavior not consistent with osdResolvedNathan CutlerActions
Copied to Ceph - Backport #19560: kraken: objecter: full_try behavior not consistent with osdResolvedNathan CutlerActions
Actions #1

Updated by Sage Weil about 7 years ago

  • Related to Bug #19133: osd ops (sent and?) arrive at osd out of order added
Actions #2

Updated by Sage Weil about 7 years ago

  • Backport set to jewel
Actions #3

Updated by Sage Weil about 7 years ago

  • Status changed from New to Fix Under Review
Actions #4

Updated by Sage Weil about 7 years ago

  • Has duplicate Bug #19540: .../rados/test.sh: line 9: 29593 Terminated (times out) added
Actions #5

Updated by Sage Weil about 7 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport changed from jewel to jewel,kraken
Actions #6

Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #19559: jewel: objecter: full_try behavior not consistent with osd added
Actions #7

Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #19560: kraken: objecter: full_try behavior not consistent with osd added
Actions #8

Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF