Project

General

Profile

Actions
Copy link

Bug #1767

closed

osd_client: send_request() cannot fail

Added by Anonymous over 12 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
v3.3
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

The static __send_request() routine is sure to succeed in queuing its request for the specified osd client, yet ceph_osdc_start_request() checks for such a failure and either logs an error or unregisters the request. Another call to __send_request() from send_queued does not check for an error.

The right thing to do is probably to change __send_request() to return void and clean up the call in ceph_osdc_start_request()

Actions
Copy link

Also available in: Atom PDF