Actions
Bug #16848
closedObjectModDesc::update_snaps does not apply the update if the object has been stashed (and stash removes update_snaps)
Status:
Rejected
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
This only comes into play when snaps are used with EC. Further, you'd have to rollback a trim operation on a clone. If that happened, this bug would mean that the rollback would not add the object back into the snap mapper and trim wouldn't get to it. The fix is probably to add a stash_and_update_snaps variant method which encodes the existing stash and update_snaps codes as well as setting rollback_info_completed. ReplicatedPG then needs to be audited to make sure that the right users are switched over.
Updated by Samuel Just over 7 years ago
Nevermind, it works as-is. rmobject() doesn't clear the bl and all users do update_snaps first.
Actions