Bug #16744
closeddebian/rules invokes cmake with -DCMAKE_BUILD_TYPE=None, builds without -g
0%
Description
Debian builds are building without -g, which, among other things, messes up gdb.
This is from dh_auto_build; while there is an override_dh_auto_build, that just augments dh_auto_build with two more commands. The cmake setup assumes that the default build type will take effect, so the explicit setting to None is breaking that assumption.
dh_auto_build doesn't do very much in the case of cmake, so the answer is probably to invoke cmake/make directly. I'm not sure exactly what the replacement should be.
See: /usr/share/perl5/Debian/Debhelper/Buildsystem/cmake.pm
Updated by Dan Mick almost 8 years ago
It's possible that this is enough; it's looking promising:
override_dh_auto_configure:
- dh_auto_configure --buildsystem=cmake -- $(extraopts) $(CEPH_EXTRA_CMAKE_ARGS)
+ dh_auto_configure --buildsystem=cmake -- $(extraopts) $(CEPH_EXTRA_CMAKE_ARGS) -DCMAKE_BUILD_TYPE=Updated by Dan Mick almost 8 years ago
That does seem to be enough to get the build type back to default and add the -g flag.
Updated by Dan Mick almost 8 years ago
- Status changed from 12 to Fix Under Review
- Assignee set to Dan Mick
commit
9ea7c49eac0d666d952c7c91f22166561ec240c8 pushed for check/gitbuild as wip-16744
Updated by Kefu Chai almost 8 years ago
another fix is available at https://github.com/ceph/ceph/pull/10366
Updated by Dan Mick over 7 years ago
- Status changed from Fix Under Review to Resolved
- Assignee changed from Dan Mick to Kefu Chai