Project

General

Profile

Actions

Feature #16568

closed

Removing head object with ceph-objectstore-tool breaks snap trimming

Added by David Zafman almost 8 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

The ceph-objectstore-tool can remove the snapdir or head object even with other snaps present. The head object is required otherwise trim_object() will crash the osd.

The fix is to remove all snapshots when removing the head or snapdir object. The existing code will already cleanup the SnapMapper, but we shouldn't allow the head/snapdir alone to be removed.

Actions #1

Updated by David Zafman almost 8 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to In Progress

Add a "removeall" object operation which will remove the head object and all snapshots. If a "remove" object operation is used and there are snaphots, this request will now fail unless a --force is used.

https://github.com/ceph/ceph/pull/10098

Actions #2

Updated by Christian Theune over 7 years ago

I think this could be helpful for us. However, as we have already lost the had objects - any chance to cover that use case, too?

Actions #3

Updated by David Zafman about 7 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF