Project

General

Profile

Actions
Copy link

Bug #15266

closed

ceph_volume_client purge failing on non-ascii filenames

Added by John Spray about 8 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
John Spray
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Manila
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     return func(self, *args, **kwargs)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/opt/stack/manila/manila/share/manager.py", line 1836, in delete_share_instance
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     {'status': constants.STATUS_ERROR_DELETING})
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     self.force_reraise()
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     six.reraise(self.type_, self.value, self.tb)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/opt/stack/manila/manila/share/manager.py", line 1818, in delete_share_instance
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     share_server=share_server)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/opt/stack/manila/manila/share/drivers/cephfs/cephfs_native.py", line 260, in delete_share
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     self.volume_client.delete_volume(self._share_path(share),
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 520, in purge_volume
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher 
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 513, in rmtree
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     rmtree(d_full)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 513, in rmtree
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     rmtree(d_full)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 513, in rmtree
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     rmtree(d_full)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 511, in rmtree
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     d_full = os.path.join(root_path, d.d_name)
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher   File "/usr/lib/python2.7/posixpath.py", line 80, in join
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher     path += '/' + b
2016-03-24 15:03:19.685 TRACE oslo_messaging.rpc.dispatcher UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)

Need to be more careful with string functions here

Related issues 1 (0 open — 1 closed)

Copied to CephFS - Backport #15971: jewel: ceph_volume_client purge failing on non-ascii filenamesResolvedJohn SprayActions
Actions
Copy link
 #1

Updated by John Spray about 8 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by John Spray about 8 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #3

Updated by Greg Farnum about 8 years ago

  • Category changed from 44 to 87
  • Assignee set to John Spray
Actions
Copy link
 #4

Updated by John Spray almost 8 years ago

  • Status changed from Fix Under Review to Pending Backport

Merged in master, needs backport to jewel.

commit e590f4d05fdb46747e83e35e66a26d9f4aa0314d
Author: John Spray <john.spray@redhat.com>
Date:   Fri Apr 1 14:27:31 2016 +0100

    pybind: fix unicode handling in CephFSVolumeClient::purge

    os.path.join is sensitive to string encoding, but
    just doing a straight substitution should not be.

    Signed-off-by: John Spray <john.spray@redhat.com>
Actions
Copy link
 #5

Updated by Nathan Cutler almost 8 years ago

  • Backport set to jewel
Actions
Copy link
 #6

Updated by Nathan Cutler almost 8 years ago

  • Copied to Backport #15971: jewel: ceph_volume_client purge failing on non-ascii filenames added
Actions
Copy link
 #7

Updated by Ramana Raja almost 8 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #8

Updated by Patrick Donnelly about 5 years ago

  • Category deleted (87)
  • Labels (FS) Manila added
Actions
Copy link

Also available in: Atom PDF