Project

General

Profile

Actions

Fix #14932

open

Improve ceph-disk error message when there is not enough space to create journal partition

Added by Nathan Cutler about 8 years ago. Updated over 7 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Owen Synge writes:

When using ceph-disk to create a journal partiton in the next available partition and their is not enough space, ceph-disk does not provide a clear error message.

Michal Jura writes:

I think that ceph-disk needs better to report some problems. Currently when we are using external SSD journal partition feature and disk space for new journal partition will finish. Ceph-disk will try to create next partition from the first sector on disk. We would like to get some error information that there is no space left for more partitions.

[Fri, 12 Sep 2014 10:24:51 +0200] INFO: Processing execute[Activating Ceph OSD on /dev/vdf] action run (ceph::osd line 159)

================================================================================
Error executing action `run` on resource 'execute[Activating Ceph OSD on /dev/vdf]'
================================================================================

Mixlib::ShellOut::ShellCommandFailed
------------------------------------
Expected process to exit with [0], but received '1'
---- Begin output of ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 ----
STDOUT: Creating new GPT entries.
GPT data structures destroyed! You may now partition the disk using fdisk or
other utilities.
Creating new GPT entries.
The operation has completed successfully.
STDERR: WARNING:ceph-disk:OSD will not be hot-swappable if journal is not the same device as the osd data
Could not create partition 4 from 31459328 to 41945087
Unable to set partition 4's name to 'ceph journal'!
Could not change partition 4's type code to 45b0969e-9b03-4f30-b4c6-b4b80ceff106!
Error encountered; not saving changes.
ceph-disk: Error: Command '['/usr/sbin/sgdisk', '--new=4:0:+5120M', '--change-name=4:ceph journal', '--partition-guid=4:a24c11ad-c32d-4a5b-b033-63f3968416ee', '--typecode=4:45b0969e-9b03-4f30-b4c6-b4b80ceff106', '--mbrtogpt', '--', '/dev/vdc']' returned non-zero exit status 4
---- End output of ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 ----
Ran ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 returned 1

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/ceph/recipes/osd.rb

159:         execute "Activating Ceph OSD on #{osd_device['device']}" do
160:           command create_cmd
161:           action :run
162:         end
163: 

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/ceph/recipes/osd.rb:159:in `from_file'

execute("Activating Ceph OSD on /dev/vdf") do
  recipe_name "osd" 
  cookbook_name "ceph" 
  returns 0
  backup 5
  retry_delay 2
  action [:run]
  command "ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1" 
  retries 0
end

[Fri, 12 Sep 2014 10:24:53 +0200] ERROR: Running exception handlers
[Fri, 12 Sep 2014 10:24:53 +0200] FATAL: Saving node information to /var/chef/cache/failed-run-data.json
[Fri, 12 Sep 2014 10:24:53 +0200] ERROR: Exception handlers complete
[Fri, 12 Sep 2014 10:24:53 +0200] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[Fri, 12 Sep 2014 10:24:53 +0200] FATAL: Mixlib::ShellOut::ShellCommandFailed: execute[Activating Ceph OSD on /dev/vdf] (ceph::osd line 159) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 ----
STDOUT: Creating new GPT entries.
GPT data structures destroyed! You may now partition the disk using fdisk or
other utilities.
Creating new GPT entries.
The operation has completed successfully.
STDERR: WARNING:ceph-disk:OSD will not be hot-swappable if journal is not the same device as the osd data
Could not create partition 4 from 31459328 to 41945087
Unable to set partition 4's name to 'ceph journal'!
Could not change partition 4's type code to 45b0969e-9b03-4f30-b4c6-b4b80ceff106!
Error encountered; not saving changes.
ceph-disk: Error: Command '['/usr/sbin/sgdisk', '--new=4:0:+5120M', '--change-name=4:ceph journal', '--partition-guid=4:a24c11ad-c32d-4a5b-b033-63f3968416ee', '--typecode=4:45b0969e-9b03-4f30-b4c6-b4b80ceff106', '--mbrtogpt', '--', '/dev/vdc']' returned non-zero exit status 4
---- End output of ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 ----
Ran ceph-disk prepare --cluster ceph --journal-dev --zap-disk /dev/vdf /dev/vdc && ceph-disk-activate /dev/vdf1 returned 1
Actions #1

Updated by Loïc Dachary about 8 years ago

  • Status changed from New to 12
  • Assignee set to Loïc Dachary
  • Target version deleted (v10.0.4)
Actions #3

Updated by Owen Synge about 8 years ago

I just tested this with SUSE version:

major:
10
minor:
0
revision:
3-928-g1ce475a
uuid:
1ce475a21c6e2fa8aa13d40b07da21554489a8c8

And it is still present, am now going to test with master.

Actions #5

Updated by Loïc Dachary about 8 years ago

  • Status changed from 12 to In Progress
Actions #6

Updated by Loïc Dachary over 7 years ago

  • Assignee deleted (Loïc Dachary)
Actions

Also available in: Atom PDF