Bug #14609: rados tool does not work with 0 length input (crashes if '--striper' enabled) - Ceph - Ceph

Actions

Copy link

Bug #14609

closed

rados tool does not work with 0 length input (crashes if '--striper' enabled)

Added by Marcel Lauhoff about 8 years ago. Updated about 7 years ago.

Status:

Resolved

Priority:

High

Assignee:

Category:

Target version:

% Done:

Source:

Community (dev)

Tags:

Backport:

jewel

Regression:

Severity:

4 - irritation

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Command:

./rados --pool=test put toyfile5 <(dd if=/dev/urandom of=- count=4 bs=1M); ./rados --pool=test get toyfile5 >(wc -c)

Output from dd:

4+0 records in
4+0 records out
4194304 bytes (4,2 MB) copied, 0,24987 s, 16,8 MB/s

Output from wc (should be 4M)

Command:

./rados --pool=test put --striper toyfile5 <(dd if=/dev/urandom of=- count=10 bs=1M)

Leads to crash (Full trace is attached):

FAILED assert(len > 0)

Files

foo (27.9 KB) foo

Marcel Lauhoff, 02/02/2016 03:27 PM

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Marcel Lauhoff about 8 years ago

Sorry, process substitution works. I did something stupid with dd. The only problem is 0 length input:

./rados --pool=test put --striper $RANDOM <(dd if=/dev/urandom count=0 bs=0)

Result: crash

Actions

Copy link

Updated by Sage Weil about 8 years ago

Subject changed from rados tool does not work with process substitution (crashes if '--striper' enabled) to rados tool does not work with 0 length input (crashes if '--striper' enabled)
Priority changed from Normal to High

Actions

Copy link

Updated by Kefu Chai over 7 years ago

Status changed from New to In Progress
Assignee set to Kefu Chai

being worked on by Shinobu Kinjo

Actions

Copy link

Updated by Kefu Chai over 7 years ago

Assignee deleted (~~Kefu Chai~~)

Actions

Copy link

Updated by Shinobu Kinjo over 7 years ago

Assignee set to Shinobu Kinjo

Actions

Copy link

Updated by Shinobu Kinjo over 7 years ago

Release set to infernalis
Release set to jewel

Reproduced in:
Infernalis: 9.2.1-31-gbaf17c9
Jewel: 10.2.5-5663-g601fb96

Actions

Copy link

Updated by Shinobu Kinjo about 7 years ago

Status changed from In Progress to Fix Under Review

~~https://github.com/ceph/ceph/commit/a211db19ddbb5c65b3152ba0154ab983220cbdc1~~

Actions

Copy link

Updated by Shinobu Kinjo about 7 years ago

Status changed from Fix Under Review to 7

Actions

Copy link

Updated by Shinobu Kinjo about 7 years ago

Status changed from 7 to In Progress

Actions

Copy link

#10

Updated by Shinobu Kinjo about 7 years ago

This bug seems to be fixed in master. I'm now trying to find out when it's fixed then back it port to older version(jewel, infernalis(, hammer?))

Actions

Copy link

#11

Updated by Nathan Cutler about 7 years ago

@Shinobu: Please note that infernalis has already been retired. We will still backport bugfixes to hammer until the luminous release, but the focus there is on fixing bugs (if any) that prevent users from upgrading to jewel. Knowing that, if you still want to submit a hammer backport for review you are welcome to do so.

Actions

Copy link

#12