Cleanup #146
closedComplete build options for Pthread API
0%
Description
Would you like to combine your check for this programming interface with the capabilities from the configuration script "ACX_PTHREAD"?
Files
Updated by Sage Weil almost 14 years ago
If there is an environment where the -lpthread isn't sufficient, sure. Send a patch! :)
Updated by Markus Elfring almost 14 years ago
- File 0001-Complete-build-options-for-Pthread-API.patch 0001-Complete-build-options-for-Pthread-API.patch added
Would you like to integrate the appended changes into your source code repository?
Updated by Sage Weil almost 14 years ago
Markus Elfring wrote:
Would you like to integrate the appended changes into your source code repository?
This gives me an error during configure:
...
checking whether make sets $(MAKE)... (cached) yes
checking for pow in -lm... yes
./configure: line 20539: syntax error near unexpected token `newline'
./configure: line 20539: `AX_PTHREAD('
make[1]: *** [config.status] Error 2
make[1]: Failed to remake makefile `Makefile'.
make[1]: Leaving directory `/home/sage/ceph'
make: *** [../config.status] Error 2
make: Failed to remake makefile `Makefile'.
make: Target `all' not remade because of errors.
Also, are there any platforms out there anyone would reasonably be using where -lpthread isn't sufficient?
Updated by Markus Elfring almost 14 years ago
...
./configure: line 20539: syntax error near unexpected token `newline'
./configure: line 20539: `AX_PTHREAD('
...
Did you apply the addition of the assignment "ACLOCAL_AMFLAGS = -I m4" in the configuration file "Makefile.am"?
Also, are there any platforms out there anyone would reasonably be using where -lpthread isn't sufficient?
Yes - The macro shows the relevant checks for compiler and linker differences.
Updated by Sage Weil over 12 years ago
- Status changed from Rejected to In Progress
- Assignee set to Markus Elfring
The patch actually looks basically fine. It just needs to be refreshed against the current master branch, and the src/Makefile.am needs to be updated appropriately (-lpthread is all over the place, IIRC).
Updated by Sage Weil over 12 years ago
- Status changed from In Progress to Rejected