Project

General

Profile

Actions
Copy link

Bug #13533

closed

PG: shall finish scrub ahead of time if no more objects is available in NEW_CHUNK state.

Added by xie xingguo over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
High
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
v0.94.2
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

void PG::chunky_scrub(ThreadPool::TPHandle &handle)
...

// special case: reached end of file store, implicitly a boundary
    if (objects.empty()) {
      break;
    }

See above, if all objects have been scrubbed, we shall finish scrub ahead of time instead of continuing perform an redundant scrub, which can make scrub less efficient.

Actions
Copy link
 #2

Updated by xie xingguo over 8 years ago

Sorry, need more work.

Actions
Copy link
 #3

Updated by Samuel Just over 8 years ago

  • Status changed from New to Rejected

While the primary doesn't have any more objects, the replicas might still have stray objects which would constitute scrub errors, so we still need to check.

Actions
Copy link
 #4

Updated by xie xingguo over 8 years ago

Samuel Just wrote:

While the primary doesn't have any more objects, the replicas might still have stray objects which would constitute scrub errors, so we still need to check.

Yup, I got it. Thank you for reminder.

Actions
Copy link

Also available in: Atom PDF