Project

General

Profile

Bug #12736

boost uuid makes valgrind complain

Added by Sage Weil over 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

the boost random number generator uses uninitialized memory as an extra source of randomness:

https://svn.boost.org/trac/boost/ticket/7248

I'm pushed a valgrind suppression but i'm not certain it'll work.. let's see!

https://github.com/ceph/teuthology/commit/13f3a9569e391f390a821d1bf522414b84db01ee


Related issues

Copied to Ceph - Backport #16343: hammer: boost uuid makes valgrind complain Resolved

Associated revisions

Revision dbcaa544 (diff)
Added by Sage Weil over 7 years ago

uuid: use boost::random:random_device

The boost mt code uses uninitialized memory for extra randomness,
which is a bad idea in general but more importantly makes valgrind
unhappy. Use /dev/urandom instead.

Unfortunately this introduces a link time dependency.. meh!

Fixes: #12736
Signed-off-by: Sage Weil <>

Revision 187d308b (diff)
Added by Sage Weil over 6 years ago

uuid: use boost::random:random_device

The boost mt code uses uninitialized memory for extra randomness,
which is a bad idea in general but more importantly makes valgrind
unhappy. Use /dev/urandom instead.

Unfortunately this introduces a link time dependency.. meh!

Fixes: #12736
Signed-off-by: Sage Weil <>
(cherry picked from commit dbcaa544856fcc99ab912a101c4a28e1eb3fb94e)

Conflicts:
ceph.spec.in (trivial resolution)

History

#1 Updated by Sage Weil over 7 years ago

  • Status changed from New to Fix Under Review

#2 Updated by Sage Weil over 7 years ago

  • Status changed from Fix Under Review to 7

#3 Updated by Sage Weil over 7 years ago

  • Assignee set to Sage Weil

#4 Updated by Sage Weil over 7 years ago

  • Status changed from 7 to Resolved

#5 Updated by Nathan Cutler over 6 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to hammer

#6 Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #16343: hammer: boost uuid makes valgrind complain added

#7 Updated by Sage Weil over 6 years ago

  • Assignee deleted (Sage Weil)

#8 Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF