Actions
Bug #12718
closedceph-disk always calls restorecon
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
restorecon must be called only if it's available. It fails all ceph-deploy run on operating systems that do not have selinux installed by default.
It was introduced by https://github.com/ceph/ceph/commit/9db80da12803d42bb676d67f37442c0c54d83448 which is part of https://github.com/ceph/ceph/pull/5421
It does not show in the nightlies because ceph-deploy suite is run on next and hammer only
2015-08-18T11:23:29.611 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] Traceback (most recent call last):
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 3204, in <module>
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] main()
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 3175, in main
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] args.func(args)
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 1844, in main_prepare
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] luks=luks
2015-08-18T11:23:29.612 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 1593, in prepare_dev
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] path = mount(dev=dev, fstype=fstype, options=mount_options)
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 1076, in mount
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] path,
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 308, in command
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] arguments = _get_command_executable(arguments)
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] File "/usr/sbin/ceph-disk", line 288, in _get_command_executable
2015-08-18T11:23:29.613 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] raise ExecutableNotFound('%s %s' % (executable_msg, command_msg))
2015-08-18T11:23:29.614 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][WARNING] __main__.ExecutableNotFound: restorecon not in path. Could not run command: restorecon /var/lib/ceph/tmp/mnt.RF4z1x
2015-08-18T11:23:29.614 INFO:teuthology.orchestra.run.target169098.stderr:[target169097][ERROR ] RuntimeError: command returned non-zero exit status: 1
Updated by Loïc Dachary over 8 years ago
- Status changed from New to 12
- Assignee set to Loïc Dachary
- Priority changed from Normal to Urgent
Updated by Loïc Dachary over 8 years ago
- Status changed from 12 to Fix Under Review
Updated by Milan Broz over 8 years ago
Interesting, I have if which('restorecon') here locally.
Some wrong patch was merged then...
Updated by Loïc Dachary over 8 years ago
- Status changed from Fix Under Review to Resolved
Actions