Cleanup #12191: Remove ceph-mds --journal-check aka ONESHOT_REPLAY - CephFS - Ceph

Actions

Copy link

Cleanup #12191

closed

Remove ceph-mds --journal-check aka ONESHOT_REPLAY

Added by John Spray almost 9 years ago. Updated almost 8 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Target version:

% Done:

Tags:

Backport:

Reviewed:

Affected Versions:

Component(FS):

MDS

Labels (FS):

Pull request ID:

Description

Now that we have separate tools for validating the journal, we should remove MDSMap::STATE_ONESHOT_REPLAY -- it adds complexity and is largely untested.

Actions

Copy link

Updated by Greg Farnum almost 9 years ago

Tracker changed from Bug to Cleanup

Actions

Copy link

Updated by John Spray about 8 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by John Spray almost 8 years ago

Status changed from In Progress to Resolved

commit edfda9c6b0a0c8b75ebff5f06017aa475339b1fd
Author: John Spray <john.spray@redhat.com>
Date:   Tue Mar 22 17:44:22 2016 +0000

    mds: remove ONESHOT_REPLAY mode

    This predated cephfs-journal-tool.  Don't bother
    with any backwards-compatibility mechanisms here, as
    it was a seriously niche undocumented thing.

    On the off chance that someone ran an old ceph-mds against
    a newer ceph-mon with oneshot enabled, it shouldn't break
    anything, it just won't do what they want.

    Signed-off-by: John Spray <john.spray@redhat.com>

Actions

Copy link