Actions
Fix #12049
openreplace snprintf(s,...); x = strlen(s); with x = snprintf...
Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
low-hanging-fruit
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
for performances
Files
Updated by Benjamin Sesia almost 9 years ago
- File research_snprintf.txt research_snprintf.txt added
I checked each snprintf of the project under ceph\src but couldn't find any of 'snprintf(s,...)' followed by a 'x = strlen(s);'
Attached : result of the research
Updated by Loïc Dachary almost 9 years ago
It looks like you may have missed a few such as https://github.com/ceph/ceph/blob/master/src/os/FileStore.cc#L1216 . Given the large number of snprintf lines, maybe it's worth trying to use a script to spot those that are of interest ?
Updated by Nathan Cutler over 8 years ago
Hint:
$ cd src/ $ grep -r -i3 strlen | less
text search for "snprintf" yields some positives
Updated by Laura Flores over 1 year ago
- Translation missing: en.field_tag_list set to low-hanging-fruit
Actions