Actions
Bug #11857
closedadmin/build-doc: script fails silently under certain circumstances
% Done:
0%
Source:
other
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
On openSUSE, admin/build-doc fails silently due to missing commands. Although the script has code for reporting which commands are missing, due to the presence of "set -e" at the beginning of the script the script bails out immediately when "command -v" returns a nonzero status.
The "set -e" was introduced by this commit: https://github.com/ceph/ceph/commit/c5a74a73d2a37825f91a89cfe2868aac4fb95260
One option would be to add error-checking code to any commands (like pip) that might fail.
If this is deemed to be too much trouble, Kefu Chai suggested we could also disable "set -e" right before "command -v" and re-enable it immediately after.
Actions