Project

General

Profile

Actions

Fix #11532

closed

make check must verify resources before running in parallel

Added by Loïc Dachary almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

if make check runs out of resources, it will fail miserably and in mysterious ways. There will be many left over process that are painful to kill. Although this can be avoided by running make check in a container, not everyone has docker installed and simply running ./run-make-check.sh will likely overflows the ulimits for machines with > 8 processors.

The resource check must be conservative because it is easier to deal with a make check run that is slower than it should be rather than a failed make check because of resources starvation.

Actions #1

Updated by Loïc Dachary almost 9 years ago

On fedora 20, with make -j12 nproc must be >= 16000 and

$ cat limits.d/ubuntu.conf 
    ubuntu hard nofile 16384

Actions #2

Updated by Loïc Dachary almost 9 years ago

  • Status changed from 12 to Fix Under Review
Actions #3

Updated by Loïc Dachary almost 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF