Project

General

Profile

Actions

Bug #11178

closed

make tags is broken again

Added by Dan Mick about 9 years ago. Updated about 7 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

make tags fails with:

make[2]: *** No rule to make target `dummy.cc', needed by `tags-am'.  Stop.

This is similar to #8530, except that the new additions for unittest_librbd and ceph_test_librbd don't use common/dummy.cc, but rather just dummy.cc. Adding common/ fixes the problem:

--- a/src/test/Makefile.am
+++ b/src/test/Makefile.am
@@ -785,7 +785,7 @@ librbd_test_la_CXXFLAGS = $(UNITTEST_CXXFLAGS)
 noinst_LTLIBRARIES += librbd_test.la

 unittest_librbd_SOURCES =
-nodist_EXTRA_unittest_librbd_SOURCES = dummy.cc
+nodist_EXTRA_unittest_librbd_SOURCES = common/dummy.cc
 unittest_librbd_LDADD = \
        librbd_test.la librbd_api.la librbd_internal.la $(LIBRBD_TYPES) \
        libcls_rbd_client.la libcls_lock_client.la \
@@ -795,7 +795,7 @@ unittest_librbd_LDADD = \
 check_PROGRAMS += unittest_librbd

 ceph_test_librbd_SOURCES =
-nodist_EXTRA_ceph_test_librbd_SOURCES = dummy.cc
+nodist_EXTRA_ceph_test_librbd_SOURCES = common/dummy.cc
 ceph_test_librbd_LDADD = \
        librbd_test.la librbd_api.la librbd_internal.la $(LIBRBD_TYPES) \
         libcls_rbd_client.la libcls_lock_client.la \

Maybe we should also add "make tags" to make check?

Actions #1

Updated by Dan Mick about 9 years ago

  • Description updated (diff)
Actions #2

Updated by Sage Weil about 7 years ago

  • Status changed from New to Won't Fix
Actions #3

Updated by Dan Mick about 7 years ago

It's actually working in cmake now.

Actions

Also available in: Atom PDF