Bug #10787
mon: OSDMonitor::map_cache is buggy, send_incremental is not conservative
0%
Description
2015-02-06 22:29:31.387753 7fed116df700 10 mon.peon5752@0(leader).osd e598595 preprocess_pgtemp osd_pgtemp(e598591 {5.7e99=[37,536,882],5.98a4=[482,738,869],5.f15b=[180,778,585],11.7e93=[37,536,882],11.989e=[482,738,869],11.f155=[180,778,585]} v598591) v1 2015-02-06 22:29:31.387773 7fed116df700 7 mon.peon5752@0(leader).osd e598595 preprocess_pgtemp e598591 no changes from osd.807 [2607:f298:4:2243::5522]:6828/3810 2015-02-06 22:29:31.387779 7fed116df700 7 mon.peon5752@0(leader).osd e598595 _reply_map 598591 from osd.807 [2607:f298:4:2243::5522]:6828/3810 2015-02-06 22:29:31.387783 7fed116df700 5 mon.peon5752@0(leader).osd e598595 send_latest to osd.807 [2607:f298:4:2243::5522]:6828/3810 start 598591 2015-02-06 22:29:31.387787 7fed116df700 5 mon.peon5752@0(leader).osd e598595 send_incremental [598591..598595] to osd.807 [2607:f298:4:2243::5522]:6828/3810 2015-02-06 22:29:31.387792 7fed116df700 10 mon.peon5752@0(leader).osd e598595 osd.807 should have epoch <b>594144</b> 2015-02-06 22:29:31.387794 7fed116df700 10 mon.peon5752@0(leader).osd e598595 build_incremental [594145..594245]
the passed-in first is > (much >!) the cached map value.
we should maybe only use the cached value here if it is larger, update the map_cache while we are here so that we do have the best value for this osd...
Associated revisions
mon/OSDMonitor: do not trust small values in osd epoch cache
If the epoch cache says the osd has epoch 100 and the osd is asking for
epoch 200+, do not send it 100+.
Fixes: #10787
Backport: giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: do not trust small values in osd epoch cache
If the epoch cache says the osd has epoch 100 and the osd is asking for
epoch 200+, do not send it 100+.
Fixes: #10787
Backport: giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a5759e9b97107488a8508f36adf9ca1aba3fae07)
mon/OSDMonitor: do not trust small values in osd epoch cache
If the epoch cache says the osd has epoch 100 and the osd is asking for
epoch 200+, do not send it 100+.
Fixes: #10787
Backport: giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a5759e9b97107488a8508f36adf9ca1aba3fae07)
History
#1 Updated by Sage Weil about 6 years ago
- Status changed from New to Fix Under Review
#2 Updated by Sage Weil about 6 years ago
- Status changed from Fix Under Review to Pending Backport
#3 Updated by Loïc Dachary about 6 years ago
- giant backport https://github.com/ceph/ceph/pull/4049
#4 Updated by Loïc Dachary about 6 years ago
- Backport changed from giant,firefy to giant,firefly
#5 Updated by Loïc Dachary about 6 years ago
#6 Updated by Loïc Dachary about 6 years ago
- Status changed from Pending Backport to Resolved