Project

General

Profile

Bug #10512

osd: cancel_flush requeues blocked events after blocking event

Added by Sage Weil almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
giant,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Associated revisions

Revision 11bdfb41 (diff)
Added by Sage Weil almost 5 years ago

osd: requeue blocked op before flush it was blocked on

If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.

This was observed on this firefly run:

ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil <>

Revision 66b13f2b (diff)
Added by Sage Weil over 4 years ago

osd: requeue blocked op before flush it was blocked on

If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.

This was observed on this firefly run:

ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil <>
(cherry picked from commit 11bdfb4131ecac16d4a364d651c6cf5d1d28c702)

Revision 5771f57a (diff)
Added by Sage Weil over 4 years ago

osd: requeue blocked op before flush it was blocked on

If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.

This was observed on this firefly run:

ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil <>
(cherry picked from commit 11bdfb4131ecac16d4a364d651c6cf5d1d28c702)

History

#1 Updated by Sage Weil almost 5 years ago

  • Status changed from Fix Under Review to Resolved

#2 Updated by Sage Weil almost 5 years ago

  • Status changed from Resolved to Pending Backport

#5 Updated by Sage Weil over 4 years ago

gaint done, firefly pending

#6 Updated by Loic Dachary over 4 years ago

5771f57 osd: requeue blocked op before flush it was blocked on (in giant), 66b13f2 osd: requeue blocked op before flush it was blocked on (in firefly),

#7 Updated by Loic Dachary over 4 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF