Project

General

Profile

Actions

Bug #10243

closed

civetweb is hitting a limit (number of threads 1024)

Added by Mustafa Muhammad over 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When setting "rgw thread pool size" to a number higher than 1024 and enabling civetweb 'rgw_frontends="civetweb port=80"', civetweb does not work because of "MAX_WORKER_THREADS" value in civetweb.c

Actions #1

Updated by Mustafa Muhammad over 9 years ago

The problem is in [1] as:
#define MAX_WORKER_THREADS 1024
I changed this to "MAX_WORKER_THREADS 20480" and it worked well.
I opened an issue upstream [2], and they fixed it [3].

I tried to make a pull request for your copy but after forking, I noticed that the pull request is for the deprecated repo:
https://github.com/sunsetbrew/civetweb
Not the active upstream:
https://github.com/bel2125/civetweb
I think this should be fixed too

[1] https://github.com/ceph/civetweb/blob/master/src/civetweb.c
[2] https://github.com/bel2125/civetweb/issues/50
[3] https://github.com/bel2125/civetweb/commit/23bdcc98dd72ac421ed0a9e82d66977089fbfe63

Actions #2

Updated by Sage Weil over 9 years ago

  • Project changed from Ceph to rgw
  • Priority changed from Normal to High
  • Source changed from other to Community (user)
Actions #3

Updated by Mustafa Muhammad over 9 years ago

Hi, any news about changing civetweb github repo?

Actions #4

Updated by Mustafa Muhammad about 9 years ago

Ping?

Actions #5

Updated by Yehuda Sadeh about 9 years ago

  • Status changed from New to Fix Under Review
Actions #6

Updated by Yehuda Sadeh about 9 years ago

  • Backport set to hammer
Actions #7

Updated by Yehuda Sadeh about 9 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #8

Updated by Loïc Dachary almost 9 years ago

  • Regression set to No
  • master commit:7a432f7bdfbbc51518fb63d7f2ecab401e8a8d4f
Actions #10

Updated by Loïc Dachary almost 9 years ago

  • Status changed from Pending Backport to Resolved
Actions #11

Updated by Mustafa Muhammad almost 9 years ago

I'm not really sure, but can't we use the "new" upstream?

Actions

Also available in: Atom PDF