Bug #10243: civetweb is hitting a limit (number of threads 1024) - rgw - Ceph

Bug #10243

civetweb is hitting a limit (number of threads 1024)

Added by Mustafa Muhammad about 9 years ago. Updated over 8 years ago.

Status:

Resolved

Priority:

High

Assignee:

Target version:

% Done:

Source:

Community (user)

Tags:

Backport:

hammer

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

When setting "rgw thread pool size" to a number higher than 1024 and enabling civetweb 'rgw_frontends="civetweb port=80"', civetweb does not work because of "MAX_WORKER_THREADS" value in civetweb.c

Associated revisions

Revision 7a432f7b (diff)
Added by Yehuda Sadeh over 8 years ago

civetweb: update max num of threads

Fixes: #10243
cherry-picked upstream fixed into submodule

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Revision 3edb1964 (diff)
Added by Yehuda Sadeh over 8 years ago

civetweb: update max num of threads

Fixes: #10243
cherry-picked upstream fixed into submodule

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit 7a432f7bdfbbc51518fb63d7f2ecab401e8a8d4f)

History

#1 Updated by Mustafa Muhammad about 9 years ago

The problem is in [1] as:
#define MAX_WORKER_THREADS 1024
I changed this to "MAX_WORKER_THREADS 20480" and it worked well.
I opened an issue upstream [2], and they fixed it [3].

I tried to make a pull request for your copy but after forking, I noticed that the pull request is for the deprecated repo:
https://github.com/sunsetbrew/civetweb
Not the active upstream:
https://github.com/bel2125/civetweb
I think this should be fixed too

[1] https://github.com/ceph/civetweb/blob/master/src/civetweb.c
[2] https://github.com/bel2125/civetweb/issues/50
[3] https://github.com/bel2125/civetweb/commit/23bdcc98dd72ac421ed0a9e82d66977089fbfe63