Bug #11178
Updated by Dan Mick about 9 years ago
make tags fails with: <pre> make[2]: *** No rule to make target `dummy.cc', needed by `tags-am'. Stop. </pre> This is similar to #8530, except that the new additions for unittest_librbd and ceph_test_librbd don't use common/dummy.cc, but rather just dummy.cc. Adding common/ fixes the problem: <pre> --- a/src/test/Makefile.am +++ b/src/test/Makefile.am @@ -785,7 +785,7 @@ librbd_test_la_CXXFLAGS = $(UNITTEST_CXXFLAGS) noinst_LTLIBRARIES += librbd_test.la unittest_librbd_SOURCES = -nodist_EXTRA_unittest_librbd_SOURCES = dummy.cc +nodist_EXTRA_unittest_librbd_SOURCES = common/dummy.cc unittest_librbd_LDADD = \ librbd_test.la librbd_api.la librbd_internal.la $(LIBRBD_TYPES) \ libcls_rbd_client.la libcls_lock_client.la \ @@ -795,7 +795,7 @@ unittest_librbd_LDADD = \ check_PROGRAMS += unittest_librbd ceph_test_librbd_SOURCES = -nodist_EXTRA_ceph_test_librbd_SOURCES = dummy.cc +nodist_EXTRA_ceph_test_librbd_SOURCES = common/dummy.cc ceph_test_librbd_LDADD = \ librbd_test.la librbd_api.la librbd_internal.la $(LIBRBD_TYPES) \ libcls_rbd_client.la libcls_lock_client.la \ </pre> Maybe we should also add "make tags" to make check?