Project

General

Profile

Actions
Copy link

Bug #9784

closed

All tools should be named consistently and argument parsing should be better

Added by David Zafman over 9 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Slowly some of the tools like ceph_objectstore_tool have migrated to have underscores in the name. But I noticed some others haven't:

Some of the commands I noticed:

ceph-osdomap-tool
ceph-monstore-tool
ceph-kvstore-tool

I assume we want to keep ceph-osd, ceph-mon to be named with dashes since they aren't executed by the user directly.

I fixed some of the argument handling in wip-toolfixes in my personal git hub repo

Actions
Copy link
 #1

Updated by Samuel Just over 9 years ago

ceph-objectstore-tool. Generally, dashes for things people actually use, underscores for tests.

Actions
Copy link
 #2

Updated by Sage Weil over 9 years ago

any tool that a user uses should have -'s. the source files should always use _'s.. just the final executable uses -'s.

a zillion unit tests and such use _'s. imo that's okay, and perhaps _ vs - is a way to distinguish between the two. i don't think it's worth converting any test binary names.

but for anything user visible.. -'s ftw!

Actions
Copy link
 #3

Updated by Sage Weil about 7 years ago

  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF