Project

General

Profile

Actions
Copy link

Bug #9579

closed

Default parameters are not getting initialized for EC profile using isa EC plugin

Added by Mallikarjun Biradar over 9 years ago. Updated over 9 years ago.

Status:
Won't Fix
Priority:
High
Assignee:
Loïc Dachary
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When created an EC profile using erasure code plugin "isa", default values for parameters k, m and technique are not getting initialized.

But, for erasure code plugin "jerasure", parameters are getting assigned with default values.

It's expected that it should initialize default values for EC profile parameters created with "isa" erasure code plug in.

ems@rack6-client-6:~$ sudo ceph osd erasure-code-profile set isaprofile plugin=isa
ems@rack6-client-6:~$
ems@rack6-client-6:~$ sudo ceph osd erasure-code-profile get isaprofile
directory=/usr/lib/ceph/erasure-code
plugin=isa
ems@rack6-client-6:~$
ems@rack6-client-6:~$ sudo ceph osd erasure-code-profile set jerasureprofile plugin=jerasure
ems@rack6-client-6:~$ sudo ceph osd erasure-code-profile get jerasureprofile
directory=/usr/lib/ceph/erasure-code
k=2
m=1
plugin=jerasure
technique=reed_sol_van
ems@rack6-client-6:~$

This issue is been observed on 0.84 CEPH.

Files

2014-09-24_18-06_ceph_debuginfo.tar.gz (669 KB) 2014-09-24_18-06_ceph_debuginfo.tar.gz Mallikarjun Biradar, 09/24/2014 05:46 AM

Related issues 1 (0 open — 1 closed)

Related to Ceph - Feature #9589: erasure-code: query plugin for erasure-code-profile defaultsResolvedLoïc Dachary09/25/2014

Actions
Actions
Copy link
 #1

Updated by Loïc Dachary over 9 years ago

  • Status changed from New to Won't Fix
  • Assignee changed from Sage Weil to Loïc Dachary

There are no defaults for k/m for the isa plugin, the parameters need to be set explicitly as documented at http://ceph.com/docs/master/rados/operations/erasure-code-isa/

Actions
Copy link
 #2

Updated by Mallikarjun Biradar over 9 years ago

From the code, it seems default value of k & m for "isa" profile are 7 & 3 respectively.

class ErasureCodeIsaDefault : public ErasureCodeIsa {

int matrixtype;

public:

static const int DEFAULT_K = 7;
  static const int DEFAULT_M = 3;
  static const int g_decode_tbls_lru_length=2516; // caches up to 12+4 completely
unsigned char* a; // encoding coefficient
  unsigned char* g_encode_tbls; // encoding table
Actions
Copy link
 #3

Updated by Loïc Dachary over 9 years ago

This is confusing and I added http://tracker.ceph.com/issues/9589 to work on improving the user experience. Thanks for your understanding.

Actions
Copy link
 #4

Updated by Loïc Dachary over 9 years ago

Documentation update on k/m, good catch ! https://github.com/ceph/ceph/pull/2571

Actions
Copy link

Also available in: Atom PDF