Project

General

Profile

Actions
Copy link

Bug #9365

closed

Logging on class load failure could be better

Added by Dan Mick over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
common
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Florian points out that if you're missing cls_rbd on your system, the debug is just horrible at figuring that out. It seems like we could help with logging. Untested, jotting down as an idea:

--- a/src/osd/ClassHandler.cc
+++ b/src/osd/ClassHandler.cc
@ -107,8 +107,11 @ int ClassHandler::_load_class(ClassData *cls)

struct stat st;
     int r = ::stat(fname, &st);
-    if (r < 0)
+    if (r < 0) {
+      dout(0) << "_load_class could not open class " << fname
+             << " stat " << fname << " returned " << r << dendl
       return -errno;
+    }
Actions
Copy link
 #1

Updated by Sage Weil over 9 years ago

  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF