Project

General

Profile

Actions

Fix #9245

closed

remove Monitor::osdmonitor_prepare_command

Added by Loïc Dachary over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Monitor
Target version:
-
% Done:

100%

Source:
other
Tags:
Backport:
giant
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

osdmonitor_prepare_command is too fragile and leads to obscure problems when it fails. A possible replacement would be a generic way to double the command being sent to a) assert it is idempotent, b) verify that it properly handles the fact that the pending incremental change has already been done.


Related issues 1 (0 open1 closed)

Related to Ceph - Feature #2732: Idempotency testerResolved07/05/2012

Actions
Actions #1

Updated by Loïc Dachary over 9 years ago

  • Subject changed from replace osdmonitor_prepare_command to replace Monitor::osdmonitor_prepare_command
  • Category set to Monitor
Actions #2

Updated by Loïc Dachary over 9 years ago

  • Status changed from 12 to Fix Under Review
  • % Done changed from 0 to 80
Actions #3

Updated by Loïc Dachary over 9 years ago

  • Subject changed from replace Monitor::osdmonitor_prepare_command to remove Monitor::osdmonitor_prepare_command
Actions #5

Updated by Sage Weil over 9 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Source changed from other to Development
  • Backport set to giant
Actions #6

Updated by Loïc Dachary over 9 years ago

  • Status changed from Pending Backport to Fix Under Review
  • Source changed from Development to other
Actions #7

Updated by Loïc Dachary over 9 years ago

  • % Done changed from 80 to 90
Actions #8

Updated by Loïc Dachary over 9 years ago

  • Status changed from Fix Under Review to Resolved
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF