Bug #9102: ceph-disk has undefined variables - Ceph - Ceph

Actions

Copy link

Bug #9102

closed

ceph-disk has undefined variables

Added by Alfredo Deza over 9 years ago. Updated over 9 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Alfredo Deza

Category:

ceph cli

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

We fail to track them because the build doesn't yell at us, in the meantime, those should be fixed.


flake8 --select=F ceph-disk
ceph-disk:1090:1: F841 local variable 'journal_file' is assigned to but never used
ceph-disk:1335:1: F821 undefined name 'prepare_lock'
ceph-disk:1467:1: F821 undefined name 'prepare_lock'
ceph-disk:1503:1: F821 undefined name 'prepare_lock'
ceph-disk:1958:1: F821 undefined name 'activate_lock'
ceph-disk:1997:1: F821 undefined name 'activate_lock'
ceph-disk:2037:1: F821 undefined name 'activate_lock'
ceph-disk:2054:1: F821 undefined name 'activate_lock'
ceph-disk:2077:1: F821 undefined name 'activate_lock'
ceph-disk:2097:1: F821 undefined name 'activate_lock'
ceph-disk:2297:1: F821 undefined name 'SUPPRESS_PREFIX'
ceph-disk:2311:1: F821 undefined name 'SUPPRESS_PREFIX'
ceph-disk:2311:1: F841 local variable 'f' is assigned to but never used
ceph-disk:2324:1: F821 undefined name 'SUPPRESS_PREFIX'