Project

General

Profile

Actions
Copy link

Bug #8345

closed

PG::repair_object() should check for and return errors

Added by David Zafman almost 10 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
High
Assignee:
-
Category:
OSD
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The function should make sure that the OI_ATTR exists.
The decode of object_info_t should should be called explicitly and errors caught.
PG::repair_object() should return int error code or 0 on success instead of void

Actions
Copy link
 #1

Updated by Sage Weil almost 10 years ago

  • Priority changed from Normal to High
  • Source changed from other to Development
Actions
Copy link
 #2

Updated by Loïc Dachary almost 10 years ago

  • Category set to OSD
  • Status changed from New to Fix Under Review
  • Assignee set to Loïc Dachary
  • % Done changed from 0 to 40
Actions
Copy link
 #3

Updated by Loïc Dachary almost 10 years ago

  • Status changed from Fix Under Review to 4
  • % Done changed from 40 to 60
Actions
Copy link
 #4

Updated by Loïc Dachary almost 10 years ago

  • Status changed from 4 to 12
  • Assignee deleted (Loïc Dachary)

Based on the discussion we had today during the standup, my understanding is that the resolution of this problem should be delayed for now.

Actions
Copy link
 #5

Updated by Loïc Dachary almost 10 years ago

  • % Done changed from 60 to 0
Actions
Copy link
 #6

Updated by Sage Weil about 7 years ago

  • Status changed from 12 to Rejected
Actions
Copy link

Also available in: Atom PDF