Project

General

Profile

Actions
Copy link

Bug #6680

closed

libcephfs.h broken for gcc

Added by Noah Watkins over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This patch https://github.com/ceph/ceph/commit/e1666d0400ecef464d33480e4290896404b7a7bd did the following:

-int ceph_create(struct ceph_mount_info **cmount, const char * const id);
+int ceph_create(class ceph_mount_info **cmount, const char * const id);

which makes gcc blow up since class isn't a thing in C. Is this a mistake, or did we drop C support for libcephfs.h?

Actions
Copy link
 #1

Updated by Sage Weil over 10 years ago

it was a cleanup for clang to not mix class vs struct. that's secondary, though.. this should definitely build in c.

Actions
Copy link
 #2

Updated by Sage Weil over 10 years ago

  • Priority changed from Normal to Urgent
Actions
Copy link
 #3

Updated by Noah Watkins over 10 years ago

d3b56918698803ce441d9b1ef0185caebed4d433

Actions
Copy link
 #4

Updated by Noah Watkins over 10 years ago

  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF