Project

General

Profile

Actions

Bug #65553

open

cephadm: agent tries to json load response payload before checking for errors

Added by Adam King 29 days ago. Updated 16 days ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
squid, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If the connection itself fails, the agent will end up hitting another exception

Failed to send metadata to mgr: the JSON object must be str, bytes or bytearray, not ConnectionRefusedError

as it tries to json.loads the response before checking the return code. This masks the real reason for the connection error.


Related issues 2 (2 open0 closed)

Copied to Orchestrator - Backport #65722: squid: cephadm: agent tries to json load response payload before checking for errorsNewAdam KingActions
Copied to Orchestrator - Backport #65723: reef: cephadm: agent tries to json load response payload before checking for errorsNewAdam KingActions
Actions

Also available in: Atom PDF