Project

General

Profile

Actions
Copy link

Bug #65553

open

cephadm: agent tries to json load response payload before checking for errors

Added by Adam King 15 days ago. Updated 1 day ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Adam King
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
squid, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
56961
Crash signature (v1):
Crash signature (v2):

Description

If the connection itself fails, the agent will end up hitting another exception

Failed to send metadata to mgr: the JSON object must be str, bytes or bytearray, not ConnectionRefusedError

as it tries to json.loads the response before checking the return code. This masks the real reason for the connection error.

Related issues 2 (2 open — 0 closed)

Copied to Orchestrator - Backport #65722: squid: cephadm: agent tries to json load response payload before checking for errorsNewAdam KingActions
Copied to Orchestrator - Backport #65723: reef: cephadm: agent tries to json load response payload before checking for errorsNewAdam KingActions
Actions
Copy link
 #1

Updated by Adam King 14 days ago

  • Pull request ID set to 56961
Actions
Copy link
 #2

Updated by Adam King 1 day ago

  • Status changed from In Progress to Pending Backport
Actions
Copy link
 #3

Updated by Backport Bot 1 day ago

  • Copied to Backport #65722: squid: cephadm: agent tries to json load response payload before checking for errors added
Actions
Copy link
 #4

Updated by Backport Bot 1 day ago

  • Copied to Backport #65723: reef: cephadm: agent tries to json load response payload before checking for errors added
Actions
Copy link
 #5

Updated by Backport Bot 1 day ago

  • Tags set to backport_processed
Actions
Copy link

Also available in: Atom PDF