Project

General

Profile

Actions

Bug #63734

closed

client: handle callback when async io fails

Added by Dhairya Parmar 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
quincy,reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

There are several cases where the async call might experience some failure and the helper functions would just return an errno but there's no code path taking care of the context completion. I experienced these issues while running [0] locally, created few trackers and started addressing them in separate PRs but soon realised that it was quite unnecessary to do, therefore I moved all the commits into a single PR; since it would be cumbersome to manage all those trackers and their backports, i'm creating this (parent) tracker.

[0] https://github.com/ceph/ceph/pull/54435

*async io failure tracker
https://tracker.ceph.com/issues/63632
https://tracker.ceph.com/issues/63648
https://tracker.ceph.com/issues/63629
https://tracker.ceph.com/issues/63619
https://tracker.ceph.com/issues/63679


Related issues 5 (0 open5 closed)

Related to CephFS - Bug #63632: client: fh obtained using O_PATH can stall the caller during async I/OClosedDhairya Parmar

Actions
Related to CephFS - Bug #63648: client: ensure callback is finished if write fails during async I/OClosedDhairya Parmar

Actions
Related to CephFS - Bug #63629: client: handle context completion during async I/O call when the client is not mountingClosedDhairya Parmar

Actions
Related to CephFS - Bug #63619: client: check for negative value of iovcnt before passing it to internal functions during async I/OClosedDhairya Parmar

Actions
Related to CephFS - Bug #63679: client: handle zero byte sync/async write casesClosedDhairya Parmar

Actions
Actions #1

Updated by Dhairya Parmar 5 months ago

  • Related to Bug #63632: client: fh obtained using O_PATH can stall the caller during async I/O added
Actions #2

Updated by Dhairya Parmar 5 months ago

  • Related to Bug #63648: client: ensure callback is finished if write fails during async I/O added
Actions #3

Updated by Dhairya Parmar 5 months ago

  • Related to Bug #63629: client: handle context completion during async I/O call when the client is not mounting added
Actions #4

Updated by Dhairya Parmar 5 months ago

  • Related to Bug #63619: client: check for negative value of iovcnt before passing it to internal functions during async I/O added
Actions #5

Updated by Dhairya Parmar 5 months ago

  • Pull request ID set to 54690
Actions #6

Updated by Dhairya Parmar 5 months ago

  • Description updated (diff)
Actions #7

Updated by Dhairya Parmar 5 months ago

  • Related to Bug #63679: client: handle zero byte sync/async write cases added
Actions #8

Updated by Venky Shankar 3 months ago

  • Status changed from In Progress to Resolved

Dhairya, this doesn't need backport IMO. Would you concur?

Actions

Also available in: Atom PDF