Project

General

Profile

Actions
Copy link

Bug #63431

closed

[test] clean up RBD_MIRROR_MODE vs MIRROR_IMAGE_MODE in rbd_mirror_helpers.sh and related scripts

Added by Ilya Dryomov 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Suyash Dongre
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
54489
Crash signature (v1):
Crash signature (v2):

Description

With the introduction of RBD_MIRROR_MODE environment variable in https://github.com/ceph/ceph/pull/48508, these are largely duplicating each other.

Actions
Copy link
 #1

Updated by Aniket Singh Rawat 6 months ago

Hello I would like to work on this issue.

Actions
Copy link
 #2

Updated by Ilya Dryomov 6 months ago

Feel free to take a stab at it! I haven't checked every use site, but I suspect we can just get rid of MIRROR_IMAGE_MODE.

Actions
Copy link
 #3

Updated by Suyash Dongre 6 months ago

Aniket Singh Rawat wrote:

Hello I would like to work on this issue.

Hey Aniket. Are you still working on the issue? I would like to take on the issue if you aren't. Thanks!

Actions
Copy link
 #4

Updated by Ilya Dryomov 6 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Suyash Dongre
  • Pull request ID set to 54489
Actions
Copy link
 #5

Updated by Ilya Dryomov 6 months ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF