Bug #62626
openmgr/nfs: include pseudo in JSON output when nfs export apply -i fails
0%
Description
Currently, when export update fails, this is the reponse:
[
{
"msg": "Failed to apply export: export FSAL user_id must be 'nfs.my-nfs.1'",
"state": "error"
},
{
"msg": "Failed to apply export: export FSAL user_id must be 'nfs.my-nfs.2'",
"state": "error"
}
]
in case of multiple export update failure, it is tedious to figure out failure for respective exports, this can be fixed with if we include export_id with and also errno to help understand the failure behind unsuccessful export update i.e. like this:
[
{
"errno": 22,
"export_id": 1,
"msg": "Failed to apply export: export FSAL user_id must be 'nfs.my-nfs.1'",
"state": "error"
},
{
"errno": 22,
"export_id": 2,
"msg": "Failed to apply export: export FSAL user_id must be 'nfs.my-nfs.2'",
"state": "error"
}
]
also add test case that tries to update multiple export(this is essential not only this tracker but for test suite as well because currently there is no test case that tests multiple exports manipulation)
Updated by Venky Shankar 8 months ago
Dhairya, could you link the commit which started causing this? (I recall we discussed a bit about this)
Updated by Dhairya Parmar 7 months ago
- Subject changed from mgr/nfs: return errno and export_id when export update fails to mgr/nfs: include pseudo in JSON output when nfs export apply -i fails
Updated by Dhairya Parmar 7 months ago
Dhairya Parmar wrote:
Currently, when export update fails, this is the reponse:
[...]
in case of multiple export update failure, it is tedious to figure out failure for respective exports, this can be fixed with if we include export_id with and also errno to help understand the failure behind unsuccessful export update i.e. like this:
[...]
also add test case that tries to update multiple export(this is essential not only this tracker but for test suite as well because currently there is no test case that tests multiple exports manipulation)
FYI From the discussion in PR [0], it was decided that pseudo will be included and NOT the export_id
[0] https://github.com/ceph/ceph/pull/53177#discussion_r1329816664
Updated by Venky Shankar 3 months ago
- Status changed from In Progress to Pending Backport
- Backport changed from reef,quincy,pacific to reef,quincy
Updated by Backport Bot 3 months ago
- Copied to Backport #64219: quincy: mgr/nfs: include pseudo in JSON output when nfs export apply -i fails added
Updated by Backport Bot 3 months ago
- Copied to Backport #64220: reef: mgr/nfs: include pseudo in JSON output when nfs export apply -i fails added