Project

General

Profile

Actions

Bug #6086

closed

ceph-deploy needs to handle ClientInitExceptions from pushy

Added by Alfredo Deza over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
ceph-deploy
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When pushy can't connect to a remote host it errors out and ceph-deploy does not handle the exception
resulting in a traceback.

This error should be handled and reported back to the user.

$ ceph-deploy purge node2dsf
[ceph_deploy.install][DEBUG ] Purging from cluster ceph hosts node2dsf
[ceph_deploy.install][DEBUG ] Detecting platform for host node2dsf ...
Traceback (most recent call last):
  File "/Users/alfredo/.virtualenvs/ceph-deploy/bin/ceph-deploy", line 8, in <module>
    load_entry_point('ceph-deploy==1.2.1', 'console_scripts', 'ceph-deploy')()
  File "/Users/alfredo/python/ceph-deploy/ceph_deploy/util/decorators.py", line 83, in newfunc
    return f(*a, **kw)
  File "/Users/alfredo/python/ceph-deploy/ceph_deploy/cli.py", line 140, in main
    return args.func(args)
  File "/Users/alfredo/python/ceph-deploy/ceph_deploy/install.py", line 214, in purge
    sudo = args.pushy(get_transport(hostname))
  File "/Users/alfredo/.virtualenvs/ceph-deploy/lib/python2.7/site-packages/pushy/client.py", line 580, in connect
    return PushyClient(target, **kwargs)
  File "/Users/alfredo/.virtualenvs/ceph-deploy/lib/python2.7/site-packages/pushy/client.py", line 364, in __init__
    self.server.stdin.write(marshal.dumps(packages, 1))
pushy.client.ClientInitException:
  [remote] ssh: Could not resolve hostname node2dsf: nodename nor servname provided, or not known
Actions #1

Updated by Alfredo Deza over 10 years ago

  • Status changed from 12 to Fix Under Review
Actions #2

Updated by Alfredo Deza over 10 years ago

  • Status changed from Fix Under Review to Resolved

Merged into ceph-deploy master branch with hash: dfaa9d3274b3c8c0dcfce94062532649bf212fb9

Basically, a simple try/except that will catch that exception and report it nicely back in the terminal/logs

Actions

Also available in: Atom PDF